Wyre@sh.itjust.works to Cybersecurity@sh.itjust.worksEnglish · 5 months agoGitHub disables XZ Repositorywww.phoronix.comexternal-linkmessage-square18fedilinkarrow-up11arrow-down10
arrow-up11arrow-down1external-linkGitHub disables XZ Repositorywww.phoronix.comWyre@sh.itjust.works to Cybersecurity@sh.itjust.worksEnglish · 5 months agomessage-square18fedilink
minus-squareKilling_Spark@feddit.delinkfedilinkEnglisharrow-up0·5 months agoSadly it does have one place with unsafe code. I needed a ringbuffer with an efficient “extend from within” implementation. I always wanted to contribute that to the standard library to actually get to no unsafe.
minus-squaresugar_in_your_tea@sh.itjust.workslinkfedilinkEnglisharrow-up0·5 months agoAh, I saw a PR from like 3 years ago that removed it, so it looks like you added it back in for performance. Have you tried contributing it upstream? I’m not a “no unsafe” zealot, but in light of the xz issue, it would be nice.
minus-squareKilling_Spark@feddit.delinkfedilinkEnglisharrow-up0·5 months ago Have you tried contributing it upstream? I didn’t yet just because I didn’t get around to it (and because I am not sure the std lib even wants this feature). I’m not a “no unsafe” zealot, but in light of the xz issue, it would be nice. I don’t think the two relate. I wouldn’t drop any dependency, the ringbuffer is implemented in the same repo.
Sadly it does have one place with unsafe code. I needed a ringbuffer with an efficient “extend from within” implementation. I always wanted to contribute that to the standard library to actually get to no unsafe.
Ah, I saw a PR from like 3 years ago that removed it, so it looks like you added it back in for performance.
Have you tried contributing it upstream? I’m not a “no unsafe” zealot, but in light of the xz issue, it would be nice.
I didn’t yet just because I didn’t get around to it (and because I am not sure the std lib even wants this feature).
I don’t think the two relate. I wouldn’t drop any dependency, the ringbuffer is implemented in the same repo.